Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the issue of failing to retrieve attachments in dubbo 2.7.6 and 2.7.7 #12982

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Resolve the issue of failing to retrieve attachments in dubbo 2.7.6 and 2.7.7 #12982

wants to merge 11 commits into from
+136 −2

Conversation

steverao
Copy link
Contributor

Resolves #12978

@steverao steverao changed the title Resolve the issue of failing to retrieve attachments in dubbo 2.7.6+ Resolve the issue of failing to retrieve attachments in dubbo 2.7.6 and 2.7.7 Jan 2, 2025
@steverao steverao marked this pull request as ready for review January 6, 2025 09:48
@steverao steverao requested a review from a team as a code owner January 6, 2025 09:48
laurit
laurit reviewed Jan 7, 2025
View reviewed changes
...tDepDubbo/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboHeadersGetterTest.java
import org.mockito.junit.jupiter.MockitoExtension;

@ExtendWith(MockitoExtension.class)
class DubboHeadersGetterTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you want to run this only for the latest dep?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you want to run this only for the latest dep?

At first, I think the main purpose is to verify that the expected method was called based on the latest dep flag. I have adjusted it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is a compatibility problem of DubboHeadersGetter#keys in Dubbo 2.7.6 and 2.7.7
2 participants
@steverao @laurit